Generate events in functions; to avoid non-discrete booleans. #4263 #4541
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generate events in functions; to avoid non-discrete booleans. Closes #4209 * Apply suggestions from code review Fix annotations. Co-authored-by: Thomas Beutlich <[email protected]> * Need Inline as well (at least for Dymola - and shouldn't be problem). * Add test-case * Update ModelicaTest/Media.mo Co-authored-by: Thomas Beutlich <[email protected]> * Inlining the function as suggested. --------- Co-authored-by: Thomas Beutlich <[email protected]>
casella
approved these changes
Feb 24, 2025
maltelenz
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Backports correctly what it claims to backport.
Since there is a new model, we will need new reference results, @GallLeo @MatthiasBSchaefer .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #4263 to Maint/4.1.x