Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal block implementation #4

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Minimal block implementation #4

merged 2 commits into from
Jul 19, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jul 18, 2024 •
edited
Loading

MFBlock class

  • acts like a dictionary of MFParameter
  • class attributes as parameter specifications
  • instance attributes as parameter values
  • introspects member parameters at load/write time and delegates load() and write()

@wpbonelli wpbonelli marked this pull request as ready for review July 19, 2024 13:47
@wpbonelli wpbonelli requested a review from mjreno July 19, 2024 13:47
mjreno
mjreno reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@mjreno mjreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mjreno mjreno merged commit 2509c9c into modflowpy:develop Jul 19, 2024
14 checks passed
@wpbonelli wpbonelli deleted the blocks branch July 19, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjreno mjreno mjreno left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpbonelli @mjreno