fix(modern-js-plugin): prevent components render multiple times if pr…

…ops change (#3139)
module-federation · Nov 15, 2024 · a50b000 · a50b000
1 parent b00aff2
commit a50b000
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 47 deletions.
diff --git a/.changeset/tender-insects-agree.md b/.changeset/tender-insects-agree.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/modern-js': patch
+---
+
+fix(modern-js-plugin): prevent components render multiple times if props change
diff --git a/packages/modernjs/src/runtime/createRemoteSSRComponent.tsx b/packages/modernjs/src/runtime/createRemoteSSRComponent.tsx
@@ -143,62 +143,63 @@ export function createRemoteSSRComponent<T, E extends keyof T>(info: {
       ? ReactKey
       : Parameters<T[E]>[0] & ReactKey
     : ReactKey;
+  const exportName = info?.export || 'default';
 
-  return (props: ComponentType) => {
-    const exportName = info?.export || 'default';
-    const LazyComponent = React.lazy(async () => {
-      try {
-        const m = (await info.loader()) as Record<string, React.FC> &
-          Record<symbol, string>;
-        if (!m) {
-          throw new Error('load remote failed');
-        }
-        const moduleId = m && m[Symbol.for('mf_module_id')];
+  const LazyComponent = React.lazy(async () => {
+    try {
+      const m = (await info.loader()) as Record<string, React.FC> &
+        Record<symbol, string>;
+      if (!m) {
+        throw new Error('load remote failed');
+      }
+      const moduleId = m && m[Symbol.for('mf_module_id')];
 
-        const assets = collectSSRAssets({
-          id: moduleId,
-        });
+      const assets = collectSSRAssets({
+        id: moduleId,
+      });
 
-        const Com = m[exportName] as React.FC;
-        if (exportName in m && typeof Com === 'function') {
-          return {
-            default: () => (
-              <>
-                {assets}
-                <Com {...props} />
-              </>
-            ),
-          };
-        } else {
-          throw Error(
-            `Make sure that ${moduleId} has the correct export when export is ${String(
-              exportName,
-            )}`,
-          );
-        }
-      } catch (err) {
-        if (!info.fallback) {
-          throw err;
-        }
-        const FallbackFunctionComponent = info.fallback;
-        const FallbackNode = (
-          <FallbackFunctionComponent
-            error={err}
-            resetErrorBoundary={() => {
-              console.log('SSR mode not support "resetErrorBoundary" !');
-            }}
-          />
-        );
+      const Com = m[exportName] as React.FC;
+      if (exportName in m && typeof Com === 'function') {
         return {
-          default: () => FallbackNode,
+          default: (props: Omit<ComponentType, 'key'>) => (
+            <>
+              {assets}
+              <Com {...props} />
+            </>
+          ),
         };
+      } else {
+        throw Error(
+          `Make sure that ${moduleId} has the correct export when export is ${String(
+            exportName,
+          )}`,
+        );
       }
-    });
-
+    } catch (err) {
+      if (!info.fallback) {
+        throw err;
+      }
+      const FallbackFunctionComponent = info.fallback;
+      const FallbackNode = (
+        <FallbackFunctionComponent
+          error={err}
+          resetErrorBoundary={() => {
+            console.log('SSR mode not support "resetErrorBoundary" !');
+          }}
+        />
+      );
+      return {
+        default: () => FallbackNode,
+      };
+    }
+  });
+  return (props: ComponentType) => {
+    const { key, ...args } = props;
     return (
       <ErrorBoundary FallbackComponent={info.fallback}>
         <React.Suspense fallback={info.loading}>
-          <LazyComponent />
+          {/* @ts-ignore */}
+          <LazyComponent {...args} />
         </React.Suspense>
       </ErrorBoundary>
     );