fix(enhanced): async boundary on dependOn named chunks #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScriptedAlchemy
force-pushed
the
fix/async-boundary-chunk-id
branch
from
2ad05f1
to
c1e2b53
Compare
ScriptedAlchemy
force-pushed
the
fix/async-boundary-chunk-id
branch
from
c1e2b53
to
7398f48
Compare
2heal1
approved these changes
Jan 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure async boundary correctly references chunks by the correct ID
When chunkIds are numbers, and dependOn is used, async boundary did not convert the string in dependOn to chunkId of the named chunk
Related Issue
#1947
Types of changes
Checklist