-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bridge-react): enable custom createRoot to support React v19 in @module-federation/bridge-react #3551
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8d65052 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
}; | ||
``` | ||
|
||
* 作用: 用于传递根组件 | ||
* `rootComponent`: 需要被远程加载的根组件 | ||
* `render`: 自定义渲染函数,用于自定义渲染逻辑 | ||
* `createRoot`: 自定义 createRoot 函数,用于自定义 React 根节点的创建方式,可用于兼容不同版本的 React 或实现特定的渲染行为 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be more advantageous to translate it into English, or keep both the code and comments in English? This way, we would reach a larger audience and also maintain a consistent language standard in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@douglaszaltron Oh, I got what you mean. I think the thing is, I forgot the English document of this part! Yes you are right,you've made a very good point. We'll definitely add English docs for this part, and I think for english users we can just turn to the english version of the website and it will all be English documents. Thank again!
This is great, it solves one of my problems in a native way. 👏👏 |
Description
feat(bridge-react): enable custom createRoot to support React v19 in @module-federation/bridge-react.
Related Issue
#3537
Types of changes
Checklist