Fixes issue #8 by providing a default 'where' value #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's been an issue with PHP7 (or MODX 2.5.7 - not totally sure which) where the user must add a &where=`[]` to the getArchives call to avoid a server 500 error. This update provides that default if no setting has been passed from the snippet call.
|
Anyone know if there is a maintainer for Archivist? Any volunteers? 😃 |
|
What is the procedure within the MODX community to become the official maintainer of an existing package? I would be interested to take this one. |
|
This pull request has been mentioned on Community. There might be relevant details there: https://community.modx.com/t/archivist-landing-page-blank/1420/1 |
|
Is this repo still maintained? This pull request needs to be merged. |
Jako
reviewed
Apr 9, 2022
| @@ -49,7 +49,7 @@ | |||
| } | |||
|
|
|||
| /* get filter by year, month, and/or day. Sanitize to prevent injection. */ | |||
| $where = $modx->getOption('where',$scriptProperties,false); | |||
| $where = $modx->getOption('where',$scriptProperties,"[]"); | |||
| $where = is_array($where) ? $where : $modx->fromJSON($where); | |||
| $parameters = $modx->request->getParameters(); | |||
There was a problem hiding this comment.
If where contains an invalid JSON, the following line has to be added.
$where = !empty($where) ? $where : array();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been an issue with PHP7 (or MODX 2.5.7 - not totally sure which) where the user must add a &where=
[]to the getArchives call to avoid a server 500 error.This update provides that default in the snippet if no setting has been passed from the snippet call.