Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice #489

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Add deprecation notice #489

merged 3 commits into from
Feb 12, 2024

Conversation

Jako
Copy link
Collaborator

@Jako Jako commented Feb 12, 2024

No description provided.

@@ -4,6 +4,9 @@ _old_id: "1691"
_old_uri: "revo/addheaderfiles"
---

!!! warning "Deprecated"
Copy link
Collaborator

@Mark-H Mark-H Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have this syntax? I've never seen it before.

We do support note in the metadata to put an obvious alert at the top.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it seems that the DocsApp does not use modern markdown code as Daux.io and Material for MkDocs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, first I've heard of that. If you want to open an issue here maybe we can add it.

@Mark-H Mark-H merged commit 604f95d into modxorg:3.x Feb 12, 2024
2 checks passed
@Jako Jako deleted the patch-5 branch February 12, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants