Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: desktop tamagotchi #7

Merged
merged 24 commits into from
Jan 3, 2025
Merged

feat: desktop tamagotchi #7

merged 24 commits into from
Jan 3, 2025

Conversation

LemonNekoGH
Copy link
Contributor

No description provided.

@LemonNekoGH LemonNekoGH requested a review from nekomeowww January 2, 2025 09:31
@LemonNekoGH LemonNekoGH self-assigned this Jan 2, 2025
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for airi-vtuber ready!

Name Link
🔨 Latest commit c021591
🔍 Latest deploy log https://app.netlify.com/sites/airi-vtuber/deploys/6777a5b6e4d8050009662399
😎 Deploy Preview https://deploy-preview-7--airi-vtuber.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/stage/package.json Outdated Show resolved Hide resolved
@LemonNekoGH LemonNekoGH requested a review from kwaa January 2, 2025 10:23
@nekomeowww
Copy link
Member

Wonderful!

@LemonNekoGH LemonNekoGH requested a review from kwaa January 2, 2025 14:56
@LemonNekoGH LemonNekoGH requested a review from kwaa January 2, 2025 16:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/stage/tamagotchi could probably be renamed to packages/stage/src-tamagotchi, like tauri's src-tauri.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think current project structure is not so graceful, the tamagotchi code invaded the stage project.

I am thinking about another way to share logics, components and styles between two project. Maybe we can extract some compoents from stage like Live2DViewer into stage-core.

But changes maybe huge so I do not know should I do these now, or create another PR later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But changes maybe huge so I do not know should I do these now, or create another PR later.

I think creating another PR will be better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge first

Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest is LGTM

@LemonNekoGH LemonNekoGH requested review from kwaa and nekomeowww January 3, 2025 07:55
npmRebuild: false
publish:
provider: generic
url: https://example.com/auto-updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What value should this be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I need to remove this now, because we don't have auto update server.

@LemonNekoGH LemonNekoGH merged commit 3c8e778 into main Jan 3, 2025
6 checks passed
@LemonNekoGH LemonNekoGH deleted the lemonnekogh/desktop branch January 3, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants