-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: desktop tamagotchi #7
Conversation
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wonderful! |
packages/stage/tamagotchi/App.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/stage/tamagotchi
could probably be renamed to packages/stage/src-tamagotchi
, like tauri's src-tauri
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think current project structure is not so graceful, the tamagotchi code invaded the stage
project.
I am thinking about another way to share logics, components and styles between two project. Maybe we can extract some compoents from stage
like Live2DViewer
into stage-core
.
But changes maybe huge so I do not know should I do these now, or create another PR later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But changes maybe huge so I do not know should I do these now, or create another PR later.
I think creating another PR will be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest is LGTM
npmRebuild: false | ||
publish: | ||
provider: generic | ||
url: https://example.com/auto-updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What value should this be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I need to remove this now, because we don't have auto update server.
No description provided.