-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally use sassc #151
base: main
Are you sure you want to change the base?
Optionally use sassc #151
Conversation
c0fd34e
to
29d01c4
Compare
Rebase on main. |
ruby's sass is officially abandoned, and it has problems with some css files, for example the latest bootstrap css, so it would be good to have the option to use sassc. Or even other sass implementations. This PR will use sassc if `MOJO_PLUGIN_ASSETPACK_SASSC` is set.
Rebased. |
Without tests i don't think this has much of a chance i'm afraid. |
I'm not sure if using a very specific envv-ar with just a boolean value bolted on the existing Sass module is ideal. I'm guessing sassc also needs a different install approach than using ruby gems? Would it make sense to add Another approach would be to be able to set the whole cmd to call with an envvar eg: The |
We're installing rubygem-sass as an openSUSE package anyway, so I don't know when
Yeah, since there's also the recommendation to use dart-sass the command line might be different for that as well. So an approach to support various implementations would be good.
IMHO adding |
Making the whole command overrideable sounds simple enough. |
Summary
This PR will use sassc if
MOJO_PLUGIN_ASSETPACK_SASSC
is set.Motivation
ruby's sass is officially abandoned, and it has problems with some css files, for example the latest bootstrap css, so it would be good to have the option to use sassc. Or even other sass implementations.
References