Day Repeater start fix #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem
`Chronic.parse("Sunday January 19, 2025 at 5pm")` and variations for the
suffix such as in yyyy-mm-dd format, etc, fail to parse, but excluding
either the year or the repeater-day resolve the issue.
## Fix
- detect the presense of repeater day + ordinal/scalar day +
ordinal/scalar year, if present and tokens_to_span returns nil,
re-run and remove the repeater-day token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Chronic.parse("Sunday January 19, 2025 at 5pm")and variations for the suffix such as in yyyy-mm-dd format, etc, fail to parse, but excluding either the year or the repeater-day resolve the issue.Fix