Fix bug - populate not working - idField mapped to undefined (issue #325, maybe #296) #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icebob
reviewed
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up bug from #254 . It was supposed to be fixed then, but I got the same issue today. To reproduce, simply use one of the tests in the commit without the fix. The _get method with _mapping: true fails with custom idFields and returns undefined for the mapping key. Since that is what is used during population, population is also broken, which could fix issues #325 and #296.
The problem was the line origDoc = doc, which did not truly copy the document, simply assigned it by reference. Our reference to the original document was thus lost during transformDocument method, as doc variable is mutated there.