Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some basic mobile / tablet styles to the Momentum homepage #13

Closed
wants to merge 4 commits into from

Conversation

lodyb
Copy link

@lodyb lodyb commented Jun 19, 2024

This PR adds some basic styles to the homepage.

I think it's in a decent state in here, there are a few minor issues that will need some design consideration after this point. They can be treated as their own separate PRs.

For example the Steam wishlist element looks bad at certain small resolutions, but I don't think there's much I can do about it.

For some reason the browser doesn't capture the fixed background on the Features section but it is still there!

Screenshot_19-6-2024_93932_localhost

src/css/main.css Outdated Show resolved Hide resolved
@lodyb lodyb requested a review from tsa96 June 20, 2024 13:35
@tsa96
Copy link
Member

tsa96 commented Jun 20, 2024

Unable to merge without creating a merge commit, which we have disable org-wide. I don't mind merge commits as much on a small repo like this, but was going to do the postcss config stuff now anyway, so I'm going to clean up the branch and do that work on top, then get everything in in one PR. In future, please rebase instead of merge commits!

@tsa96 tsa96 mentioned this pull request Jun 20, 2024
@tsa96
Copy link
Member

tsa96 commented Jun 20, 2024

Closing as superseded by #14

Really appreciate the work here. If you want to keep working on it go ahead, otherwise I can do the final styling as we're preparing to deploy this site.

@tsa96 tsa96 closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants