fix: broken delayloadlist if map selector list is ever empty

momentum-mod · Nov 16, 2024 · 78d36f4 · 78d36f4
1 parent e5eb305
commit 78d36f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/layout/pages/map-selector/map-selector.xml b/layout/pages/map-selector/map-selector.xml
@@ -160,7 +160,7 @@
 									</Panel>
 								</Panel>
 
-								<Panel class="w-full">
+								<Panel class="w-full h-fill">
 									<DelayLoadList id="MapListContainer" class="mapselector__list" itemheight="54px" itemwidth="100%" spacersize="3px" spacerperiod="1">
 										<!-- Populated via MapEntry snippets in code -->
 									</DelayLoadList>

diff --git a/styles/pages/map-selector/map-selector.scss b/styles/pages/map-selector/map-selector.scss
@@ -86,6 +86,9 @@
 	// Elements are MapEntrys, in mapentry.scss
 	&__list {
 		flow-children: down;
+		// Important note: always ensure a DelayLoadList has a non-zero height, if having 0 items results in 0 height,
+		// it'll never repaint itself when items are added.
+		height: 100%;
 		padding-right: 16px;
 		width: 100%;
 		overflow: squish scroll;