Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incident-79] send null instead of 0 for buyer external_reference_id #114

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[incident-79] send null instead of 0 for buyer external_reference_id #114

merged 1 commit into from
Apr 18, 2024

Conversation

tikohov20
Copy link
Contributor

@tikohov20 tikohov20 commented Apr 16, 2024 •
edited
Loading

Description

Fix for a bug where 0 was sent as external_reference_id instead of null

Release information

Release: p
Tickets: PT-1370

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings

ivan-pugach-mondu
ivan-pugach-mondu approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ivan-pugach-mondu ivan-pugach-mondu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tikohov20 tikohov20 merged commit 9dcfef3 into main Apr 18, 2024
@tikohov20 tikohov20 deleted the incident-79-dont-send-0-as-external-reference-id branch April 18, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-pugach-mondu ivan-pugach-mondu ivan-pugach-mondu approved these changes

@ume3119 ume3119 Awaiting requested review from ume3119

@arthurmmoreira arthurmmoreira Awaiting requested review from arthurmmoreira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikohov20 @ivan-pugach-mondu