feat(smoketests): run tests on readonly and isolated too COMPASS-8128 #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Feb 10, 2025
.evergreen/functions.yml
Outdated
| @@ -678,8 +678,14 @@ functions: | |||
|
|
|||
| if [[ "$IS_WINDOWS" == "true" ]]; then | |||
| npm run --unsafe-perm --workspace @mongodb-js/compass-smoke-tests start -- --package=windows_setup --tests time-to-first-query | |||
| npm run --unsafe-perm --workspace @mongodb-js/compass-smoke-tests start -- --package=windows_zip --tests auto-update-from | |||
| npm run --unsafe-perm --workspace @mongodb-js/compass-smoke-tests start -- --package=windows_msi --tests auto-update-from | |||
| if [[ "$HADRON_DISTRIBUTION" == "compass-isolated"]]; then | |||
There was a problem hiding this comment.
Part of me wants to keep this functions.yml clean so it specifies the full set for the default compass distribution case and then rather just override the tests parameter inside the cli to exclude the variants that won't work with the distribution.
There was a problem hiding this comment.
I think we can easily clean this in the GHA:
lerouxb
commented
Feb 12, 2025
| import { createSandbox } from '../directories'; | ||
| import { getTestSubject } from '../test-subject'; | ||
|
|
||
| export async function testReadOnly(context: SmokeTestsContext) { |
There was a problem hiding this comment.
This whole file is basically a copy/paste of time-to-first-query.ts. We can probably refactor it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.