Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6082): update dependencies #171

Merged
merged 2 commits into from
Apr 22, 2024
Merged

chore(NODE-6082): update dependencies #171

merged 2 commits into from
Apr 22, 2024

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@addaleax
Copy link
Contributor

See #172 for the CI failures here

@baileympearson baileympearson marked this pull request as ready for review April 22, 2024 16:56
@aditi-khare-mongoDB
Copy link
Contributor

Is there any reason we aren't updating the following dependency?
node-gyp ^10.0.1 → ^10.1.0

@aditi-khare-mongoDB aditi-khare-mongoDB self-requested a review April 22, 2024 18:49
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 22, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Apr 22, 2024
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the one comment!

@aditi-khare-mongoDB aditi-khare-mongoDB merged commit 2dbae40 into main Apr 22, 2024
9 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the NODE-6082 branch April 22, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants