Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure docs per Diátaxis framework #233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

timgraham
Copy link
Collaborator

@timgraham timgraham commented Jan 27, 2025

Add intro, reference, and topic sections

The Diátaxis framework is how Django's documentation is structured, so anyone coming from Django will see the parallels.

@timgraham timgraham force-pushed the intersphinx-django-https branch 7 times, most recently from ab68e23 to ae26783 Compare February 3, 2025 15:37
@timgraham timgraham marked this pull request as ready for review February 3, 2025 15:37
Comment on lines 137 to 138
:setting:`USER`, :setting:`PASSWORD`, and :setting:`PORT` (if 27017) may also
be optional.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have it say, if you do not require authentication, :setting:USER and :setting:PASSWORD should be omitted.

Suggested change
:setting:`USER`, :setting:`PASSWORD`, and :setting:`PORT` (if 27017) may also
be optional.
:setting:`USER` and :setting:`PASSWORD` should be omitted if you do not require authentication.
:setting:`PORT` (if 27017) may also be optional.

Comment on lines +150 to +153
MONGODB_URI = "mongodb+srv://my_user:[email protected]/myDatabase?retryWrites=true&w=majority&tls=false"
DATABASES["default"] = django_mongodb_backend.parse_uri(MONGODB_URI)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 16 to 18
If you're new to Django_, you might want to start by getting an idea of
what it's like. The :doc:`official Django tutorial
<django:intro/tutorial01>` is a great place to start. Once you understand
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also point to our Getting Started on the MongoDB docs as well. The Django Tutorial site won't make it clear how they should run the app using the library.

Comment on lines 15 to 18
.. function:: parse_uri(uri, conn_max_age=0, test=None)

Parses a MongoDB URI into a dictionary suitable for Django's
:setting:`DATABASES` setting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Like any database, MongoDB has some particularities. Also keep in mind that
because MongoDB is a NoSQL database, it's impossible to implement SQL-specific
functionality.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
functionality.
functionality.
If you notice an issue not listed or would like a feature that has yet to be implemented, visit the Issues & Help section of `docs/source/internals.rst` for instructions on how to file a ticket.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above needs verbal workshopping but directing folks, but it's a good idea to still direct folks to where to make requests, especially if they are already looking at the limitations.

@aclark4life
Copy link
Collaborator

Do we have RTD configured to build PRs for previewing and if not, can we configure RTD to build PRs for previewing?

@timgraham
Copy link
Collaborator Author

Do we have RTD configured to build PRs for previewing and if not, can we configure RTD to build PRs for previewing?

I'm not aware of such functionality.

To build this locally:

[alias]
    pr = !sh -c \"git fetch origin pull/${1}/head:pr/${1} && git checkout pr/${1}\"

Add thist to your ~/.gitconfig. Then you can run git pr #### to checkout the corresponding pull request.

Then cd docs && make html && firefox build/html/index.html.

@aclark4life
Copy link
Collaborator

I'm not aware of such functionality.

To build this locally:

Thanks! I enabled "build PRs" in RTD so next push should do it. 🤞

Add intro, reference, and topic sections
@timgraham timgraham force-pushed the intersphinx-django-https branch from ae26783 to 1986472 Compare February 14, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants