CLOUDP-280012: internal/dryrun/transport: simplify #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-urbaniak
force-pushed
the
CLOUDP-280012-simplify-transport
branch
from
bd19862 to
e7af14f
Compare
s-urbaniak
had a problem deploying
to
openshift-test
GitHub Actions
Failure
josvazg
reviewed
Feb 3, 2025
s-urbaniak
had a problem deploying
to
openshift-test
GitHub Actions
Failure
s-urbaniak
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
josvazg
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good news: we can nicely simplify the dry run transport, there is no need to dependency inject the event recorder to it. As a consequence, we also don't need to bubble down the runtime object any more which is needed for recording events.
It turned out this is all doable in the dry-run manager itself.
Note this has to be merged after the 2.7 release only.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).