Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-298237: Implement greediness deactivation and skips #2086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Feb 3, 2025

  • Do not delete containers when the last applied list is empty, meaning network peerings were not previously managed by the project controller.
  • Skip reconciliation of network peerings when the last skipped list is empty, meaning network peerings had been migrated off the project using the skip reconciliation flag beforehand.
  • Skip removal of network peerings when the reconciliation is deactivated (last skipped list is empty), otherwise remove only the owned network peers with IDs recorded in the status.

All Submissions:

  • Have you signed our CLA?

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Do not merge for now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants