Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip alignment issue for mobile and tab views (@HariramakrishnanK) #6205

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

HariramakrishnanK
Copy link
Contributor

Description

Fixed tooltip alignment issue for mobile and tablet views (#6042) and formated the CSS file for improved readability

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #6042

  • Updated CSS for better tooltip positioning and formatted the file for readability.
  • Tested on mobile and tablet views (images attached below).

Mobile View
Tab View

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 23, 2025
frontend/static/css/balloon.min.css Outdated Show resolved Hide resolved
@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 23, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 24, 2025
@monkeytypegeorge monkeytypegeorge removed the assets Languages, themes, layouts, etc. label Jan 24, 2025
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 25, 2025
@Miodec Miodec merged commit 86cb17b into monkeytypegame:master Feb 3, 2025
11 checks passed
@Miodec
Copy link
Member

Miodec commented Feb 3, 2025

Bit of a bandaid fix but if it works it works. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff waiting for review Pull requests that require a review before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip of Raw and Consistency in the mobile view not having enough margin left
4 participants