Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi clock filter #1755

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Midi clock filter #1755

merged 3 commits into from
Jan 22, 2024

Conversation

catfact
Copy link
Collaborator

@catfact catfact commented Jan 20, 2024

addresses #1754 by means of a new clock parameter clock_midi_in. options are "all", "none", or a vport index.

this seems to work, but needs:

  • some cleanup (dbg prints)
  • consideration of UI
  • consideration of structure / efficiency (some quick and dirty loops and maybe not optimal FFI)

define new system parameter `clock_midi_in`
@tehn
Copy link
Member

tehn commented Jan 20, 2024

thanks for getting deep into this--- i'll be able to jump in tomorrow!

@tehn
Copy link
Member

tehn commented Jan 20, 2024

the softcut includes were not intended, correct?

@catfact
Copy link
Collaborator Author

catfact commented Jan 21, 2024

correct. PR includes a reversion to any changes (i think? It was hasty) but they are still marked as dirty or whatever

@tehn tehn merged commit 666bf5a into monome:main Jan 22, 2024
@catfact catfact changed the title [WIP] Midi clock filter Midi clock filter Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants