bump client to v0.34.1 and spec version to 2601 #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshaben
added
the
A2 - Maintenance Minor
themacexpert
approved these changes
Dec 9, 2023
| @@ -276,7 +276,7 @@ Since you'll be interacting with the `transferMultiasset` function of the X-Toke | |||
| !!! note | |||
| For an `AccountId32`, `AccountIndex64`, or `AccountKey20`, you have the option of specify a `network` parameter. If you don't specify one, it will default to `None`. | |||
|
|
|||
| 3. Set the destination weight limit to `Unlimited`. In JavaScript, you'll need to set `Unlimited` to `null` (as outlined in the [TypeScript interface for `XcmV3WeightLimit`](https://github.com/moonbeam-foundation/moonbeam/blob/{{ networks.moonbase.spec_version }}/typescript-api/src/moonbase/interfaces/augment-api-tx.ts#L5734){target=_blank}): | |||
| 3. Set the destination weight limit to `Unlimited`. In JavaScript, you'll need to set `Unlimited` to `null` (as outlined in the [TypeScript interface for `XcmV3WeightLimit`](https://github.com/moonbeam-foundation/moonbeam/blob/{{ networks.moonbase.spec_version }}/typescript-api/src/moonbase/interfaces/augment-api-tx.ts#L3045){target=_blank}): | |||
There was a problem hiding this comment.
This is a nitpick but in some places we say Set the destWeightLimit to Unlimitedand in other place we spell it out as Set the destination weight limit to Unlimited. It might be good to pick one way and use consistently
There was a problem hiding this comment.
I'll double-check this in the XCM overhaul and apply any changes there
There was a problem hiding this comment.
Looks like this is already taken care of in the XCM overhaul!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps the client version to v0.34.1 and the runtime version to 2601 (not 2602 yet because there is no GitHub release tag for 2602. Checking with Andrea about this)
Goes with CN PR: moonbeam-foundation/moonbeam-docs-cn#372