Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update polkadot.js apps examples to use polkadot.js api #813

Merged
merged 1 commit into from
Dec 12, 2023
Merged

update polkadot.js apps examples to use polkadot.js api #813

merged 1 commit into from
Dec 12, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Dec 12, 2023

Description

Update the example on the Balances page to use Polkadot.js API instead of Polkadot.js Apps.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images

Items to be Updated

Need to remove balances-3.png and balances-4.png

@eshaben eshaben requested a review from themacexpert December 12, 2023 06:43
themacexpert
themacexpert approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@themacexpert
Copy link
Contributor

Friendly reminder to add a label

@albertov19 albertov19 added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Dec 12, 2023
@eshaben
Copy link
Contributor Author

eshaben commented Dec 12, 2023

@themacexpert thanks for the reminder @albertov19 thanks for the label!

@eshaben eshaben merged commit 09fb9cb into master Dec 12, 2023
1 check passed
@eshaben eshaben deleted the eshaben/account-balances branch December 12, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themacexpert themacexpert themacexpert approved these changes

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eshaben @themacexpert @albertov19