Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block production/Technical features #207

Merged
merged 34 commits into from
Dec 15, 2024

Conversation

augustocollado
Copy link
Contributor

@augustocollado augustocollado commented Nov 28, 2024

Description

This PR adds Symbiotic in the technical features article from the learn section.
It also includes some mermaid diagrams, requiring another PR to be merged in the tanssi mkdocs repo

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in tanssi-mkdocs to update redirects

@augustocollado augustocollado added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Nov 28, 2024
@augustocollado augustocollado marked this pull request as ready for review December 2, 2024 13:46
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Left some general feedback :)

We need to also center the Mermaid diagrams (horizontally)

Comment on lines 22 to 26
The Tanssi protocol provides block production as a service, orchestrating a decentralized and trustless set of sequencers, ensuring the appchains' liveness. To do so, the protocol bridges both ends:

- **Node operators** - who run sequencers, offering their block production services to get rewards
- **Appchains** - which require transactions to be executed and included in blocks, keeping the network's liveness

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is a bit confusing. "To do so, the protocol bridges both ends" I'm unsure how this relates to the list below. It feels a bit repetitive tho as it is a bit the same but in a list.

Maybe just skip the bullet list and go to the next paragraph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't very clear, indeed. I changed it so both bridged ends are the actors node operators and develoeprs. wdyt?

learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the Symbiotic part now! I think generally speaking we have to make better use of mermaid diagrams. A diagram that is very simple it is not that worthwhile.

Also I think we have to go a bit more in-depth on the protocol, Symbiotic, and how everything ties together.

learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good! Some extra feedback

learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/appchain-services/block-production.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved

## Tanssi with Symbiotic {: #tanssi-symbiotic }

Developers launching appchains through Tanssi benefit from [block production services](/learn/tanssi/appchain-services/block-production/){target=\_blank}, data retrievability as a service, and the shared security model derived from every vault opting-in to support the Tanssi protocol. This eliminates the hurdle of dealing with infrastructural and security components developers would need to take on otherwise.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we are including data retrievability as a service (which I agree we should) we should mention this across the board, and think of writing an article about this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! We should have an article in the "appchain services" section. The catch is that the mainnet will be launched without this feature and will be implemented later.
We don't know yet how this works in terms of incentives, etc

learn/tanssi/external-security-providers/symbiotic.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nitpicking 😬

@augustocollado augustocollado merged commit 93ce831 into main Dec 15, 2024
1 check passed
@augustocollado augustocollado deleted the augustocollado/block-production branch December 15, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants