Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lukem/index page learn #212

Merged
merged 25 commits into from
Dec 20, 2024
Merged

Conversation

0xlukem
Copy link
Contributor

@0xlukem 0xlukem commented Dec 10, 2024

Description

Learn Index page update to use the new cards and the “in this section” sub-template.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in tanssi-mkdocs to update redirects

@0xlukem 0xlukem added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Dec 10, 2024
@0xlukem 0xlukem requested a review from eshaben December 10, 2024 19:22
@eshaben eshaben changed the base branch from main to lukem/index-page-builders December 11, 2024 20:04
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I switched the base branch to lukem/index-page-builders because all of the builders index pages were showing up here and it made it easier for me to review after making that switch.

Left a few comments about some minor things, but this is great! 🙂

learn/appchains/index.md Outdated Show resolved Hide resolved
learn/appchains/index.md Outdated Show resolved Hide resolved
learn/appchains/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
learn/tanssi/index.md Outdated Show resolved Hide resolved
learn/tanssi/index.md Outdated Show resolved Hide resolved
learn/tanssi/network-features/staking.md Outdated Show resolved Hide resolved
@0xlukem 0xlukem requested a review from eshaben December 12, 2024 00:28
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up nicely! Almost there!!

learn/appchains/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
learn/index.md Outdated Show resolved Hide resolved
learn/index.md Show resolved Hide resolved
learn/tanssi/technical-features.md Outdated Show resolved Hide resolved
learn/tanssi/included-templates.md Outdated Show resolved Hide resolved
learn/tanssi/index.md Show resolved Hide resolved
learn/index.md Show resolved Hide resolved
learn/index.md Outdated Show resolved Hide resolved
0xlukem

This comment was marked as outdated.

0xlukem and others added 2 commits December 16, 2024 09:45
Add changes According to feedback

Co-authored-by: Erin Shaben <[email protected]>
@0xlukem 0xlukem requested a review from eshaben December 16, 2024 15:28
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The icons look great!!

The last piece here seems to be some minor cleanup plus switching "appchain" to "network". We only have to worry about making these updates on the index.md pages since Augusto modified the content pages. So please check over all of the index pages in the learn section and update them as needed! 🙂

learn/appchains/tx-fees.md Show resolved Hide resolved
learn/index.md Outdated Show resolved Hide resolved
learn/index.md Outdated Show resolved Hide resolved
learn/appchains/index.md Outdated Show resolved Hide resolved
learn/appchains/index.md Outdated Show resolved Hide resolved
learn/tanssi/index.md Outdated Show resolved Hide resolved
learn/tanssi/index.md Outdated Show resolved Hide resolved
learn/tanssi/index.md Outdated Show resolved Hide resolved
learn/tanssi/network-features/index.md Outdated Show resolved Hide resolved
learn/index.md Outdated Show resolved Hide resolved
0xlukem and others added 2 commits December 18, 2024 15:15
@0xlukem 0xlukem requested a review from eshaben December 18, 2024 21:51
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few things!

learn/appchains/index.md Outdated Show resolved Hide resolved
learn/tanssi/network-features/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
learn/framework/index.md Outdated Show resolved Hide resolved
apply changes according to the feedback

Co-authored-by: Erin Shaben <[email protected]>
@0xlukem 0xlukem requested a review from eshaben December 19, 2024 12:40
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

* update node operators index WIP

* update all index on Node

* Change descriptions from appchain nodes to network nodes and from block producers to sequencers.

* Change the name folders to the new names

* Apply suggestions from code review

Update according to feedback

Co-authored-by: Erin Shaben <[email protected]>

* update all icons according to feedback

* Apply suggestions from code review

Add changes according to feedback

Co-authored-by: Erin Shaben <[email protected]>

* update according feedback WIP

* update run a sequencer index with hardware recommendations

* remove hardware recommendations int he docs

* fix typo

* Add node description to main index

* change folders name appchain-node to network-node and fix links

* change folders name block-producers to sequencers and fix links

* fix typo

* Update node-operators/sequencers/onboarding/index.md

fix link

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/onboarding/index.md

fix typo

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/onboarding/run-a-sequencer/index.md

minor change

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/onboarding/run-a-sequencer/index.md

minor fix

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/operational-tasks/upgrade-your-node/index.md

minor fix

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/operational-tasks/upgrade-your-node/index.md

wording

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: Erin Shaben <[email protected]>
@0xlukem 0xlukem merged commit f7b7fe7 into lukem/index-page-builders Dec 20, 2024
@0xlukem 0xlukem deleted the lukem/index-page-Learn branch December 20, 2024 14:46
0xlukem added a commit that referenced this pull request Dec 20, 2024
* update index in builders

* change index to new style cards

* update cards index pages, WIP

* update index

* update index

* update all index to the new cards layout

* remove images from index-page builders

* Hides XCM related articles

* Hides XCM from the learn section

* add hide: toc to all builders index page

* Update indexs according to feedback

* wip index

* wip

* update indexs

* fix mermaid bug

* Runtime features

* reformat index pages

* update index pages

* restore index pages from other sections to avoid conflicts

* update a couple more

* add icons to appchain build and appchain template index

* add icons to customize your appchain index and docs

* add icons to deploy your appchain index and docs

* add icons to manage your appchain index and docs

* add icons to ethereum tools and docs

* add icons to sustrate tools and docs

* add icons to integrations and docs

* add icons to account mgt and docs

* add icons to Tanssi neworks index and docs

* update icons according to feedback WIP

* update icons according to feedback WIP

* finish update icons according to feedback

* change appchains for networks in index WIP

* finish change words appchain to networks

* Apply suggestions from code review

Appy changes according to feedback

Co-authored-by: Erin Shaben <[email protected]>

* Update builders/manage/dapp/index.md

quick fix

Co-authored-by: Erin Shaben <[email protected]>

* Update builders/manage/index.md

fix typo

Co-authored-by: Erin Shaben <[email protected]>

* Lukem/index page learn (#212)

* workflow fix

* resolve workflow issue

* Hides XCM related articles

* Hides XCM from the learn section

* learn general index update

* update index appchain test

* update appchain index

* update index tanssi

* update network features index

* add icons to tanssi index

* add icons to framework index

* fix overview icons and add icons to appchains index

* fix typo index learn

* rearrange Learn Index and add missing icons to index pages

* Apply suggestions from code review

apply feedback

Co-authored-by: Erin Shaben <[email protected]>

* Add changes according to feedback

* Update learn/index.md

Add changes According to feedback

Co-authored-by: Erin Shaben <[email protected]>

* changes according to the latest feedback

* Apply suggestions from code review

apply changes according to feedback

Co-authored-by: Erin Shaben <[email protected]>

* change words appchains for networks in index

* Apply suggestions from code review

apply changes according to the feedback

Co-authored-by: Erin Shaben <[email protected]>

* Lukem/index page node (#214)

* update node operators index WIP

* update all index on Node

* Change descriptions from appchain nodes to network nodes and from block producers to sequencers.

* Change the name folders to the new names

* Apply suggestions from code review

Update according to feedback

Co-authored-by: Erin Shaben <[email protected]>

* update all icons according to feedback

* Apply suggestions from code review

Add changes according to feedback

Co-authored-by: Erin Shaben <[email protected]>

* update according feedback WIP

* update run a sequencer index with hardware recommendations

* remove hardware recommendations int he docs

* fix typo

* Add node description to main index

* change folders name appchain-node to network-node and fix links

* change folders name block-producers to sequencers and fix links

* fix typo

* Update node-operators/sequencers/onboarding/index.md

fix link

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/onboarding/index.md

fix typo

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/onboarding/run-a-sequencer/index.md

minor change

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/onboarding/run-a-sequencer/index.md

minor fix

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/operational-tasks/upgrade-your-node/index.md

minor fix

Co-authored-by: Erin Shaben <[email protected]>

* Update node-operators/sequencers/operational-tasks/upgrade-your-node/index.md

wording

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: Ilaria Enache <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: augustocollado <[email protected]>
Co-authored-by: augustocollado <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: augustocollado <[email protected]>
Co-authored-by: augustocollado <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Ilaria Enache <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants