Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site health improvements - january report #224

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Site health improvements - january report #224

merged 2 commits into from
Jan 22, 2025

Conversation

0xlukem
Copy link
Contributor

@0xlukem 0xlukem commented Jan 9, 2025

Description

Updated Tanssi Docs site health according to the January SEMrush report by addressing various issues, including resolving 403 and 404 errors, fixing broken links, and adding missing ALT attributes to images. Additionally, implemented several minor improvements.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in tanssi-mkdocs to update redirects

@0xlukem 0xlukem requested a review from a team as a code owner January 9, 2025 19:19
@eshaben eshaben added the C1 - Medium Medium priority task label Jan 14, 2025
@eshaben eshaben mentioned this pull request Jan 14, 2025
Closed
1 task
@eshaben eshaben added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Jan 14, 2025
eshaben
eshaben reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches! Just a couple minor things

builders/toolkit/ethereum-api/dev-env/index.md Outdated Show resolved Hide resolved
builders/deploy/dapp.md Outdated Show resolved Hide resolved
@0xlukem @eshaben
Apply suggestions from code review
01486be 
Apply changes according to feedback

Co-authored-by: Erin Shaben <[email protected]>
@0xlukem 0xlukem requested a review from eshaben January 14, 2025 15:01
eshaben
eshaben approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet! First one for Tanssi in the books for ya! 🚢

@eshaben eshaben added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 17, 2025
@eshaben eshaben merged commit ed15f4e into moondance-labs:main Jan 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to be Merged Pull request is ready to be merged C1 - Medium Medium priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xlukem @eshaben