Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference to branch from variable #51

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Reference to branch from variable #51

merged 1 commit into from
Nov 14, 2023

Conversation

augustocollado
Copy link
Contributor

Description

This PR replaces the branch references in the articles to point to a variable

Checklist

  • If this page requires a disclaimer, I have added one
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects

@augustocollado augustocollado requested review from eshaben and removed request for albertov19 November 14, 2023 15:04
eshaben
eshaben approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a question - does it make sense to change the variable to repository.moonkit.release_branch? just in case you ever have to access the tanssi repository release branch?

@augustocollado augustocollado merged commit efb0bc8 into main Nov 14, 2023
1 check passed
@augustocollado augustocollado deleted the augustocollado/replace-repository-branch branch November 14, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustocollado @eshaben