Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new navigation pane for inspector #1142

Merged
merged 11 commits into from
Sep 13, 2024
Merged

new navigation pane for inspector #1142

merged 11 commits into from
Sep 13, 2024

Conversation

badetitou
Copy link
Member

@badetitou badetitou commented Jul 26, 2024

This is a proposal for a new navigation pane for the Moose Inspector.
It is based solely on moose description for now.

image

@badetitou badetitou marked this pull request as draft July 26, 2024 08:42
@badetitou
Copy link
Member Author

I show here the current state of my proposal.
Only one new tab.
When inspecting a MooseModel

image

A MooseGroup of classes
image

It is possible to extend to explore quickly the concepts of a class

image
Thus you can explore quickly the attributes of a class and the invocation of this attribute

Note that compare to before, when you have the entry attributes. I directly display the number of attributes.

The same here
image

I directly know that the declaredType of getServiceBatchManager is IServiceBatchManager

In the entity inspector:
image
Before
image

So you less have to explore to get simple information

@badetitou
Copy link
Member Author

Any opinion on this UI @fuhrmanator? (I tag you since you react on the Issue)

@badetitou
Copy link
Member Author

Maybe the one for Moose model can be like this to group some elements together

image

I also remember that we should take care for performance. I have now some lags for large collection. I think because I sort by printname. I should reremove it

@NicolasAnquetil
Copy link
Contributor

Hello. Nice job. May be you could separate the associations (Access, inheritance, ...) from the Entities (Class, Method, ...) ?

Another thing would be to also separate "technical entities (sourceAnchors, SourceLanguage) but there, I don't know how you could do it ? May be everything that inhrits from FamixSourceAnchor ?

@badetitou
Copy link
Member Author

Ok, I'll look at these suggestions. Thanks for the proposal

@NicolasAnquetil
Copy link
Contributor

thanks for doing it !

@fuhrmanator
Copy link
Contributor

This looks great! It's a huge improvement. Can't wait to try it on some TypeScript models.

@badetitou
Copy link
Member Author

I integrated #1141 (comment) in this PR leading main navigation to looks like
image

I propose to integrate this PR. It will add another navigation pane in second position so everybody can test both easily and then we can improve or change

@badetitou badetitou marked this pull request as ready for review September 6, 2024 12:37
@NicolasAnquetil
Copy link
Contributor

Be careful with the navigatino panes. There are alreadyt many.
I like the "raw" pane for MooseEntities, but because there are many panes, it is always one of the last and if you have one window with 2 pane displayed (Ctrl-G) hten it means it is not accessible :-(

@badetitou
Copy link
Member Author

For last version. I kill the navigation pane and the properties pane.
The properties pane is hidden by default. You can click on a simple button to show it.
I already part of the work if we want to have the "show the properties pane" in the moose settings

image

In final this PR

  • reduce the number of pane
  • add more navigation option (tree)
  • add more contextual information in navigation (for instance, if you navigate to an object, you also have the string representation of this object, not only the name of the properties)
  • simplify access of properties

But remove the sort of table of navigation properties

@jecisc jecisc merged commit 55bbd71 into development Sep 13, 2024
7 checks passed
@jecisc jecisc deleted the 1141-navigation-pane branch September 13, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants