Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/lint: ignore "pkg/*test" directories in coverage analysis #283

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

adamdecaf
Copy link
Member

@adamdecaf adamdecaf commented Feb 7, 2024

We use these as test helpers so they don't need tests themselves.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14cc776) 29.29% compared to head (158306b) 29.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   29.29%   29.29%           
=======================================
  Files           3        3           
  Lines          99       99           
=======================================
  Hits           29       29           
  Misses         66       66           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamdecaf adamdecaf changed the title go/lint: ignore test directories in coverage analysis go/lint: ignore "pkg/*test" directories in coverage analysis Feb 7, 2024
@adamdecaf adamdecaf merged commit 54b58a1 into moov-io:master Feb 7, 2024
4 checks passed
@adamdecaf adamdecaf deleted the ignore-test-packages branch February 7, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants