Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobble to Libre.fm & keep Last.fm stats clean by scrobbling only the first returned (album) artist. #18

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

0nse
Copy link

@0nse 0nse commented Feb 5, 2016

Update: Support Libre.fm. If a session key does not exist yet, the user is prompted to do create one using their Web browser.

Please note that changes to the configuration schema had to be made. These are explained in the README.

Everything below is about scrobbling the primary artist (which was the original pull request).


Current problem: If one plays a track by multiple artists, these are scrobbled by concatenating them using a semicolon. For one, ID3v2.3 recommends using slashes. Moreover, this creates a lot of new pages on Last.fm for artists that collaborate with others, when using Spotify. Additional information about this problem can be found in mopidy/mopidy#1389.

This pull request:

  • Use slashes instead of semicolon (currently only used in logging)
  • If existing, scrobble the album artist(s) instead of concatenating track artist names, except if the album artist name is "Compilation", "Split" or "Various Artists" (case insensitive)
  • The first returned artist is being scrobbled as it is considered the primary artist
  • I have tested it for a month now and it works as intended

Effects:

Drawbacks:

  • If mopidy provides multiple artists for a sane reason, they will no longer be scrobbled in a concatenated manner but only the first returned (album) artist will be. Imho, this is prone to ruin Last.fm stats anyways and therefore scrobbling the primary artist should be preferred in any case.

In the end, this pull request remains a workaround for mopidy/mopidy#1389. Personally, I prefer this solution but you might want to consider creating a dedicated branch instead of merging it onto master.

@0nse 0nse changed the title Keep Last.fm stats clean by scrobbling only the first returned (album) artist. Scrobble to Libre.fm & keep Last.fm stats clean by scrobbling only the first returned (album) artist. Feb 13, 2016
@marsjaninzmarsa
Copy link

Why not follow native Spotify scrobbler behavior, converting additional artists to feats in name?

@0nse
Copy link
Author

0nse commented Aug 24, 2017

I hadn't been aware of the behaviour you are describing. In fact, when I implemented this, I remember the official Spotify app fucking up scrobbles similarly.

Nowadays I'm hardly ever using the mopidy-scrobbler anymore. You are welcome to improve on this PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants