-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrobble to Libre.fm & keep Last.fm stats clean by scrobbling only the first returned (album) artist. #18
Open
0nse
wants to merge
17
commits into
mopidy:main
Choose a base branch
from
0nse:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change and the Network generalisation to allow submitting information to Libre.fm
Why not follow native Spotify scrobbler behavior, converting additional artists to feats in name? |
I hadn't been aware of the behaviour you are describing. In fact, when I implemented this, I remember the official Spotify app fucking up scrobbles similarly. Nowadays I'm hardly ever using the mopidy-scrobbler anymore. You are welcome to improve on this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Support Libre.fm. If a session key does not exist yet, the user is prompted to do create one using their Web browser.
Please note that changes to the configuration schema had to be made. These are explained in the README.
Everything below is about scrobbling the primary artist (which was the original pull request).
Current problem: If one plays a track by multiple artists, these are scrobbled by concatenating them using a semicolon. For one, ID3v2.3 recommends using slashes. Moreover, this creates a lot of new pages on Last.fm for artists that collaborate with others, when using Spotify. Additional information about this problem can be found in mopidy/mopidy#1389.
This pull request:
Effects:
Drawbacks:
In the end, this pull request remains a workaround for mopidy/mopidy#1389. Personally, I prefer this solution but you might want to consider creating a dedicated branch instead of merging it onto master.