Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nullable parameter type hint explicitly nullable #186

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

nimah79
Copy link

@nimah79 nimah79 commented Jan 19, 2025

Is solves the following deprecation messages in PHP 8.4:

DEPRECATED  Morilog\Jalali\Jalalian::__construct(): Implicitly marking parameter $timezone as nullable is deprecated, the explicit nullable type must be used instead in vendor/morilog/jalali/src/Jalalian.php on line 47.

DEPRECATED  Morilog\Jalali\Jalalian::now(): Implicitly marking parameter $timeZone as nullable is deprecated, the explicit nullable type must be used instead in vendor/morilog/jalali/src/Jalalian.php on line 81.

DEPRECATED  Morilog\Jalali\Jalalian::fromFormat(): Implicitly marking parameter $timeZone as nullable is deprecated, the explicit nullable type must be used instead in vendor/morilog/jalali/src/Jalalian.php on line 105.

DEPRECATED  Morilog\Jalali\Jalalian::forge(): Implicitly marking parameter $timeZone as nullable is deprecated, the explicit nullable type must be used instead in vendor/morilog/jalali/src/Jalalian.php on line 110.

DEPRECATED  Morilog\Jalali\Jalalian::fromDateTime(): Implicitly marking parameter $timeZone as nullable is deprecated, the explicit nullable type must be used instead in vendor/morilog/jalali/src/Jalalian.php on line 120.

@morilog morilog merged commit 61cfb87 into morilog:master Jan 21, 2025
8 checks passed
@morilog
Copy link
Owner

morilog commented Jan 21, 2025

I accidently press sync with original repository and, all my changes have been gone. I reverted to v3.4.2 and your changes have been gone. please open a new merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants