Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper type checking for device_eval_microbatch_size #3368

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Proper type checking for device_eval_microbatch_size #3368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7da0028
type
snarayan21 Jun 6, 2024
c660a91
Merge branch 'dev' into saaketh/dems_type
snarayan21 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer/core/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def _get_initial_device_eval_microbatch_size(
),
) from e
return batch_size
elif isinstance(device_eval_microbatch_size, Union[int, float]):
elif isinstance(device_eval_microbatch_size, (int, float)):
return device_eval_microbatch_size
else:
raise ValueError("device_eval_microbatch_size must be an int or ``'auto'``")
Loading