Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jpeg quality option #818

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

cabreraalex
Copy link

Description of changes:

Adds option for JPEG quality.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@karan6181
Copy link
Collaborator

Hey @cabreraalex , thanks for creating a PR. One minor comment, can you please update your PR with the changes that are not relevant to this PR? Seems like there are some spacing changes, single/double quotes changes, etc.

@cabreraalex
Copy link
Author

oops yup, done

Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabreraalex Thanks for adding this! Would be great to have a unit test for this functionality as well before merging.

streaming/base/format/mds/encodings.py Outdated Show resolved Hide resolved
@snarayan21
Copy link
Collaborator

@cabreraalex Mind addressing the review comments when you have some time? Thanks!

streaming/base/format/mds/encodings.py Outdated Show resolved Hide resolved
streaming/base/format/mds/encodings.py Outdated Show resolved Hide resolved
@cabreraalex
Copy link
Author

AFAI can tell just the config is passed, e.g. from jpeg:12 only the 12 is passed to from_str:

def _get_coder(encoding: str) -> Optional[Encoding]:

There is no formal type for the quality, just integer

self.quality = quality

@classmethod
def from_str(cls, config: str) -> Self:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also add a test for this too then, to also confirm what it should look like when used. Thanks!

@snarayan21
Copy link
Collaborator

@cabreraalex Mind adding the test that @ethantang-db mentioned and we can get this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose JPEG compression level
5 participants