fix: return error in authorize publish (#31)

moscajs · Jul 20, 2020 · 84b1cbb · 84b1cbb
1 parent 834434a
commit 84b1cbb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/lib/authorizer.js b/lib/authorizer.js
@@ -47,7 +47,7 @@ Authorizer.prototype.authenticate = function () {
 Authorizer.prototype.authorizePublish = function () {
   var that = this
   return function (client, packet, cb) {
-    cb(null, minimatch(packet.topic, that._users.get(client.user).authorizePublish || defaultGlob))
+    cb(minimatch(packet.topic, that._users.get(client.user).authorizePublish || defaultGlob) ? null : Error('Publish not authorized'))
   }
 }
 

diff --git a/test/authorizer.test.js b/test/authorizer.test.js
@@ -34,11 +34,14 @@ test('add user and authenticate/authorize', async function (t) {
   var notAllowed = { topic: 'not/allowed' }
   var allowed = { topic: 'allowed/topic/1' }
 
-  res = await authorizePub(client, notAllowed)
-  t.equal(res, false, 'should not authorize pub on not allowed topics')
-
-  res = await authorizePub(client, allowed)
-  t.equal(res, true, 'should authorize pub on allowed topics')
+  try {
+    res = await authorizePub(client, notAllowed)
+  } catch (error) {
+    t.equal(error.message, 'Publish not authorized', 'should not authorize pub on not allowed topics')
+  }
+
+  await authorizePub(client, allowed)
+  t.pass('should authorize pub on allowed topics')
 
   res = await authorizeSub(client, notAllowed)
   t.equal(res, null, 'should not authorize sub on not allowed topics')