Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES-1601] Captcha validation support during send-binding-otp (#961) #1120

Merged

Conversation

Md-Humair-KK
Copy link

  • capcha validation

  • organized imports

  • reverted maven mirror changes

  • already changed earlier

  • added property tag for oidc

  • Removed API rate limit changes

  • fixed test case issues

  • changed binding otp to v2 flow

  • addressed review comments

  • removed unwanted variable

  • review comments fixed

  • review comments fixed

  • review fixes

  • correct the test case

  • review comments fixed


* capcha validation

Signed-off-by: Md-Humair-KK <[email protected]>

* organized imports

Signed-off-by: Md-Humair-KK <[email protected]>

* reverted maven mirror changes

Signed-off-by: Md-Humair-KK <[email protected]>

* already changed earlier

Signed-off-by: Md-Humair-KK <[email protected]>

* added property tag for oidc

Signed-off-by: Md-Humair-KK <[email protected]>

* Removed API rate limit changes

Signed-off-by: Md-Humair-KK <[email protected]>

* fixed test case issues

Signed-off-by: Md-Humair-KK <[email protected]>

* changed binding otp to v2 flow

Signed-off-by: Md-Humair-KK <[email protected]>

* addressed review comments

Signed-off-by: Md-Humair-KK <[email protected]>

* removed unwanted variable

Signed-off-by: Md-Humair-KK <[email protected]>

* review comments fixed

Signed-off-by: Md-Humair-KK <[email protected]>

* review comments fixed

Signed-off-by: Md-Humair-KK <[email protected]>

* review fixes

Signed-off-by: Md-Humair-KK <[email protected]>

* correct the test case

Signed-off-by: Md-Humair-KK <[email protected]>

* review comments fixed

Signed-off-by: Md-Humair-KK <[email protected]>

---------

Signed-off-by: Md-Humair-KK <[email protected]>
@aranaravi aranaravi merged commit 4d9d8ac into mosip:release-1.5.1-temp Jan 17, 2025
15 checks passed
zesu22 pushed a commit to Infosys/esignet that referenced this pull request Jan 29, 2025
…) (mosip#1120)

* capcha validation

* organized imports

* reverted maven mirror changes

* already changed earlier

* added property tag for oidc

* Removed API rate limit changes

* fixed test case issues

* changed binding otp to v2 flow

* addressed review comments

* removed unwanted variable

* review comments fixed

* review comments fixed

* review fixes

* correct the test case

* review comments fixed

---------

Signed-off-by: Md-Humair-KK <[email protected]>
Signed-off-by: Zeeshan Mehboob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants