[INJIMOB-2525]: Fix help button design consistentcy across different screens #1753
+27
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckupandrestore and also changed style in homescreenlayout to fix overlapping of Inji logo with help button Signed-off-by: sairam-girirao_infosys <[email protected]>
Signed-off-by: sairam-girirao_infosys <[email protected]>
swatigoel
requested changes
Jan 13, 2025
| @@ -213,23 +213,13 @@ const BackupAndRestoreScreen: React.FC<BackupAndRestoreProps> = props => { | |||
| source={'BackUp'} | |||
| triggerComponent={ | |||
| <LinearGradient | |||
| style={{borderRadius: 8}} | |||
| style={{borderRadius: 8, marginRight: 4}} | |||
There was a problem hiding this comment.
can we extract out this style as theme component. It's being used here as well https://github.com/mosip/inji-wallet/pull/1753/files#diff-f6e082e54712a0498b18f387bd2ed941a62dcd8b8adfd448aaf0ff3083e65211R135
Or having Help as separate icon component to be used everywhere to achieve consistency and to avoid changes at multiple places for any change in future
|
@Sairam-g9162 the |
Signed-off-by: sairam-girirao_infosys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue ticket number and link
Screenshots