Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to patch the
ProxyStream
implementation, since the old relied on the fields.source
and.sinks
ofMulticastSource
being protected. In @most/core they're now private fields.Also I removed the circular stream tests from
attach
, sinceI added some more tests for
attach
though.I renamed some variables in
ProxyStream.ts
for my own sanity (sorry though).I guess this PR is a breaking change because
ProxyStream
implementation changed quite a bit and I am not confident I recreated all the old behaviour (e.g. circular streams)So at least it remains to bump the version number.