-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add I hate money #352
base: main
Are you sure you want to change the base?
Add I hate money #352
Conversation
Does the container support read-only mode? |
No, the container writes the environment variables in /etc/ihatemoney/ihatemoney.cfg and also requires a writable /tmp. Unfortunately, the container does not work rootless either, as the container writes the gid to /etc/group at the first start if you want to use an alternative gid |
I have now experimented a bit with read-only and that works when /mash/ihatemoney/data is mounted to /etc/ihatemoney/. However, this assumes that /mash/ihatemoney/data belongs to root:root. The owner mash:mash does not work, even if you pass the ids via env file. I have implemented this in the tag v6.1.5-1. Or tag v6.1.5-0 without read-only and without mount to /etc/ihatemoney, then there is no file with the owner root:root in /mash/ihatemoney. |
docs/services/ihatemoney.md
Outdated
# To enable the Admin dashboard, first generate a hashed password with: | ||
# docker run -it --rm --entrypoint ihatemoney ihatemoney/ihatemoney generate_password_hash | ||
#ihatemoney_admin_password: | ||
ihatemoney_environment_variable_public: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unclear what ihatemoney_environment_variable_public
actually does.
Should it be set to true
at some point later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your instance is meant to be open for everyone to freely create projects, you would set it to true.
If your instance is intended for private use, and you want to restrict project creation to users with the admin password, you would set it to false (or simply not set it, as false is the default).
I have adapted the documentation a little, now it should be clearer
Co-authored-by: Slavi Pantaleev <[email protected]>
Co-authored-by: Slavi Pantaleev <[email protected]>
Co-authored-by: Slavi Pantaleev <[email protected]>
Co-authored-by: Slavi Pantaleev <[email protected]>
There are several Ansible variables defined in the role that do not seem to be used:
These are all defined in |
These lines in the role confuse me: # Controls the ihatemoney environment debug variable
ihatemoney_environment_variable_ihatemoney_port: 8000 Is the comment a typo? |
In the role two environment variables are commented out:
Are these supposed to be commented out? If they don't do anything it may be better to just remove them |
This PR adds the ansible-role for i hate money.
I hope that this time I have thought of all the places where a new service needs to be added.