Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix METRO transit mode filter #745

Merged
merged 1 commit into from
Feb 16, 2025
Merged

fix METRO transit mode filter #745

merged 1 commit into from
Feb 16, 2025

Conversation

schaerfo
Copy link
Contributor

Fix #744

@schaerfo
Copy link
Contributor Author

Also, I noticed that subways are apparently included in RAIL mode, but trams are not, is that intentional?

@felixguendling
Copy link
Member

Thank you! :)

@felixguendling felixguendling merged commit 514e2f2 into motis-project:master Feb 16, 2025
11 of 12 checks passed
@felixguendling
Copy link
Member

Also, I noticed that subways are apparently included in RAIL mode, but trams are not, is that intentional?

I think it's debatable. Subway and trams both do not have the comfort of "big rail". If we change it, my idea would be to remove subway from RAIL. But on the other hand this would be a braking change and probably not worth it. Especially because anyone who didn't like the grouping as it is now can just list all modes separately.

@schaerfo schaerfo deleted the fix-744-metro-filter branch February 16, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering for metropolitan rail not working
2 participants
@schaerfo @felixguendling