Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve trip display name heuristics #163

Merged

Conversation

jbruechert
Copy link
Contributor

No description provided.

@jbruechert jbruechert force-pushed the trip-display-name-heuristics branch 2 times, most recently from 99f7a82 to c7ce393 Compare January 5, 2025 21:03
@jbruechert jbruechert force-pushed the trip-display-name-heuristics branch from c7ce393 to a5edeb7 Compare January 5, 2025 21:06
@jbruechert
Copy link
Contributor Author

This at least fixes empty strings for MAV and names like "A1" in Austria. If there is documentation on how google maps uses the different values, that would probably be useful to improve this further.

@Altonss
Copy link
Contributor

Altonss commented Jan 6, 2025

This at least fixes empty strings for MAV and names like "A1" in Austria. If there is documentation on how google maps uses the different values, that would probably be useful to improve this further.

Some information about how Google Maps handles this is available here: https://developers.google.com/transit/gtfs/data-modeling/route-modeling-guide .

@jbruechert
Copy link
Contributor Author

Some information about how Google Maps handles this is available here: https://developers.google.com/transit/gtfs/data-modeling/route-modeling-guide .

Interesting, sounds like they only use the route name?

@Altonss
Copy link
Contributor

Altonss commented Jan 6, 2025

Some information about how Google Maps handles this is available here: https://developers.google.com/transit/gtfs/data-modeling/route-modeling-guide .

Interesting, sounds like they only use the route name?

Yes, basically their logic is :
route_short_name or route_long_name (route_short_name overrides route_long_name, if given in the feed)

@jbruechert jbruechert force-pushed the trip-display-name-heuristics branch 9 times, most recently from 8c106fc to e517c14 Compare January 7, 2025 14:30
@jbruechert jbruechert force-pushed the trip-display-name-heuristics branch from e517c14 to b51de50 Compare January 7, 2025 14:36
@jbruechert
Copy link
Contributor Author

I think the results in the test files also look significantly better now

@felixguendling felixguendling merged commit 4e158cd into motis-project:master Jan 7, 2025
10 checks passed
@jbruechert jbruechert deleted the trip-display-name-heuristics branch January 7, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants