Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unsupported position constraints in OMPL (backport #2417) #2621

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 19, 2023

This is an automatic backport of pull request #2417 done by Mergify.
Cherry-pick of b0401e9 has failed:

On branch mergify/bp/humble/pr-2417
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit b0401e91a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   moveit_planners/ompl/ompl_interface/src/planning_context_manager.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_planners/ompl/ompl_interface/src/detail/ompl_constraints.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Handle unsupported position constraints in OMPL

OMPL constrained planning assumes that all position constraints have three
dimensions, meaning that they are represented by a BOX bounding volume.
If another shape is used (like a SPHERE from moveit_core/kinematic_constraints/utils.hpp),
the constraint adapter implementation will produce a segfault because of
the lack of dimensions. This fix prevents this by checking for the
required BOX type.

* Add warning if more than one position primitive is used

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit b0401e9)

# Conflicts:
#	moveit_planners/ompl/ompl_interface/src/detail/ompl_constraints.cpp
@mergify mergify bot added the conflicts label Dec 19, 2023
Copy link

github-actions bot commented Feb 5, 2024

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts stale Inactive issues and PRs are marked as stale and may be closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant