Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): render image file with base href #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thenaim
Copy link

@thenaim thenaim commented Apr 24, 2022

No description provided.

@lightningspirit
Copy link
Contributor

Thank you for your contribution 💯

According to the specs of editor-js/image plugin, the url field must contain a full public path hence, the relative path is just not recommended:

file - uploaded file data. Must contain an url field with full public path to the uploaded image. Also, can contain any additional fields you want to store. For example, width, height, id etc. All additional fields will be saved at the file object of output data.

Can you please elaborate in which scenarios (using the Editor.js) would this return a relative path?

Please, take into consideration that the purpose of this package is to render Editor.js features only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants