Skip to content

Commit

Permalink
rofi-pass: honor default_autotype in config
Browse files Browse the repository at this point in the history
The file "analyzer" was checking whether the pass file contained an
"autotype" field: if it did, it would do nothing; and if it didn't, then
it would use a hardcoded "autotype" value (user :tab pass).

This caused issues down the line because the code that would use the
config's values would always find an existing "autotype" value (whether
hardcoded in rofi-pass or supplied by the pass file), and would never be
able to apply the settings from the config file.

I would suggest (re)-using the fields ("autotype" in that case) with
values in order of preference; but for the moment, this patch does the
job.

1. autotype="user :tab pass" # hardcoded
2. if config exists and supplies it, then autotype="whatever is in
   config"
3. if the pass file supplies it, then autotype="whatever is in pass
   file"

Fixes carnager#227
  • Loading branch information
moviuro committed Apr 8, 2023
1 parent b8f8d5e commit a0fe9f2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions rofi-pass
Original file line number Diff line number Diff line change
Expand Up @@ -412,12 +412,6 @@ mainMenu () {
stuff["${_id}"]=${_val}
fi
done < <(printf '%s\n' "${fields}")

if test "${stuff['autotype']+autotype}"; then
:
else
stuff["autotype"]="${USERNAME_field} :tab pass"
fi
fi
fi

Expand Down

0 comments on commit a0fe9f2

Please sign in to comment.