Only run integration tests on lumigator code changes #776
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with: | ||
| filters: | | ||
| test: | ||
| - '.github/**' |
There was a problem hiding this comment.
Please add also the .env.template file (and I'm sure there are other paths we need to check too but I can't remember them right now :-/)
There was a problem hiding this comment.
Probably we should execute those with everything Docker-related, WDYT?
There was a problem hiding this comment.
Probably... In the end, the template will provide env var values that will get into the images / containers 🤔
There was a problem hiding this comment.
Yeah, if we change something in those files, and we don't test it, it could be problematic
There was a problem hiding this comment.
Could you add those @chainlink ?
javiermtorres
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
This only run the integration tests if the lumigator code has changed (not the helm chart or docs)
How to test it
N/A