Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for multiple ray clusters while using existing ray operator #873

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

chainlink
Copy link
Member

@chainlink chainlink commented Feb 14, 2025

What's changing

This separates out the helm dep conditions for the ray cluster and operator, following the convention of naming the condition after the chart name

Refs #828
Closes #872

How to test it

Steps to test the changes:

Test disabling kuberay-operator

$ helm template lumigator lumigator --set backend.s3Bucket=blah,backend.postgresql.enabled=false,backend.kuberay-operator.enabled=false | kubeval --ignore-missing-schemas
WARN - Set to ignore missing schemas
PASS - lumigator/charts/frontend/templates/nginx-cm.yaml contains a valid ConfigMap (nginx-conf)
PASS - lumigator/charts/backend/templates/service.yaml contains a valid Service (lumigator-backend)
PASS - lumigator/charts/frontend/templates/service.yaml contains a valid Service (lumigator-frontend)
PASS - lumigator/charts/backend/templates/deployment.yaml contains a valid Deployment (lumigator-backend)
PASS - lumigator/charts/frontend/templates/deployment.yaml contains a valid Deployment (lumigator-frontend)
WARN - lumigator/charts/backend/charts/ray-cluster/templates/raycluster-cluster.yaml containing a RayCluster (lumigator-kuberay) was not validated against a schema

Test disabling kuberay-cluster

$ helm template lumigator lumigator --set backend.s3Bucket=blah,backend.postgresql.enabled=false,backend.kuberay-operator.enabled=false,backend.ray-cluster.enabled=false | kubeval --ignore-missing-schemas
WARN - Set to ignore missing schemas
PASS - lumigator/charts/frontend/templates/nginx-cm.yaml contains a valid ConfigMap (nginx-conf)
PASS - lumigator/charts/backend/templates/service.yaml contains a valid Service (lumigator-backend)
PASS - lumigator/charts/frontend/templates/service.yaml contains a valid Service (lumigator-frontend)
PASS - lumigator/charts/backend/templates/deployment.yaml contains a valid Deployment (lumigator-backend)
PASS - lumigator/charts/frontend/templates/deployment.yaml contains a valid Deployment (lumigator-frontend)

Additional notes for reviewers

Anything you'd like to add to help the reviewer understand the changes you're proposing.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@chainlink chainlink changed the base branch from main to add-helm-deps February 14, 2025 16:27
@chainlink chainlink marked this pull request as ready for review February 14, 2025 16:35
@chainlink chainlink requested a review from macaab26 February 14, 2025 16:35
Base automatically changed from add-helm-deps to main February 17, 2025 14:15
@chainlink chainlink enabled auto-merge (squash) February 17, 2025 16:11
@chainlink chainlink disabled auto-merge February 17, 2025 16:11
@chainlink chainlink enabled auto-merge (squash) February 17, 2025 16:11
@chainlink chainlink merged commit 016a7b1 into main Feb 17, 2025
17 checks passed
@chainlink chainlink deleted the kuberay-condition branch February 17, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Allow For multiple ray clusters while using existing ray operator
2 participants