Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1812144 - Homescreen is scrollable even if there is no content #28813

Closed
wants to merge 1 commit into from
Closed

Conversation

gitstart
Copy link
Contributor

Homescreen Appbar is scrollable even if there is no content, from customize homepage all options disabled and then the appbar is scrolling if you tap on the bar and scroll up.

  • HomeScreen

Issue Screenshots

fnx-60-issue.webm

Fix Screenshots

fnx-60-fix.webm

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

GitHub Automation
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1812144

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@gitstart gitstart marked this pull request as ready for review February 10, 2023 07:05
@gitstart gitstart requested review from a team as code owners February 10, 2023 07:05
@csadilek
Copy link
Contributor

csadilek commented Feb 10, 2023

Hey @gitstart, Thank you so much for your contribution. It’s much appreciated. Unfortunately, we are in the process of moving this repository to firefox-android early next week, and won’t be able to review or land any PRs until after the migration. Please feel free to reopen a new PR against the new repo once migration is complete. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see #26855.

@csadilek csadilek closed this Feb 10, 2023
@gitstart
Copy link
Contributor Author

gitstart commented Feb 13, 2023

Hey @gitstart, Thank you so much for your contribution. It’s much appreciated. Unfortunately, we are in the process of moving this repository to firefox-android early next week, and won’t be able to review or land any PRs until after the migration. Please feel free to reopen a new PR against the new repo once migration is complete. You will have to clone the new repository and reapply your changes. Thank you again, and sorry for the inconvenience.

For more information, please see #26855.

Okay @csadilek, totally understandable..
will definitely repost the PRs when the MonoRepo is ready.
Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants