Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCO-3067]: ADR for async gcs client #788

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

Herraj
Copy link
Contributor

@Herraj Herraj commented Feb 10, 2025

References

JIRA: DISCO-3067

Description

ADR for async gcs client

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@Herraj Herraj self-assigned this Feb 10, 2025
@Herraj Herraj force-pushed the disco-3067-adr-async-gcs-client branch from e9a236f to 3dd1aa2 Compare February 10, 2025 21:32
@Herraj Herraj requested a review from a team February 10, 2025 21:32
Copy link
Contributor

@misaniwere misaniwere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! left a nit comment for thought

docs/adr/0005-asynchronous-gcs-client.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for putting this up together!

Let's index this by adding it to docs/SUMMARY.md.

docs/adr/0005-asynchronous-gcs-client.md Outdated Show resolved Hide resolved
docs/adr/0005-asynchronous-gcs-client.md Outdated Show resolved Hide resolved
docs/adr/0005-asynchronous-gcs-client.md Outdated Show resolved Hide resolved
docs/adr/0005-asynchronous-gcs-client.md Outdated Show resolved Hide resolved
@Herraj Herraj force-pushed the disco-3067-adr-async-gcs-client branch from 3dd1aa2 to 2cfe279 Compare February 11, 2025 17:13
@Herraj Herraj force-pushed the disco-3067-adr-async-gcs-client branch from 2cfe279 to dd402e6 Compare February 11, 2025 19:24
@Herraj Herraj added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 0e769b6 Feb 12, 2025
11 checks passed
@Herraj Herraj deleted the disco-3067-adr-async-gcs-client branch February 12, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants