Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCO-3226] Fix flaky amo backend unit test #789

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

Herraj
Copy link
Contributor

@Herraj Herraj commented Feb 11, 2025

References

JIRA: DISCO-3226

Description

Found another flaky unit test that was failing on captured log output assertions. This test was failing because it was encountering an extra / leaked log output (WARN level) from other place.

I couldn't trace that extra leaky log output but I was able to set the level of logs we want to capture for this set.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@Herraj Herraj self-assigned this Feb 11, 2025
@Herraj Herraj requested a review from a team February 11, 2025 19:59
@Herraj Herraj force-pushed the fix-flaky-amo-unit-test branch from 4af0e5d to 08347f2 Compare February 11, 2025 21:47
@Herraj Herraj force-pushed the fix-flaky-amo-unit-test branch from 08347f2 to fce395b Compare February 11, 2025 21:51
Copy link
Contributor

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Herraj Herraj added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 3170f58 Feb 12, 2025
11 checks passed
@Herraj Herraj deleted the fix-flaky-amo-unit-test branch February 12, 2025 16:12
@misaniwere misaniwere mentioned this pull request Feb 19, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants