[DISCO-3240] fix: merino weather to use corrected cities #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiftran
commented
Feb 14, 2025
| @@ -19,7 +18,6 @@ | |||
| CITY_NAME_CORRECTION_MAPPING: dict[str, str] = { | |||
| "Baie Ste. Anne": "Baie-Sainte-Anne", | |||
| "Bogota D.C.": "Bogota", | |||
| "Collingwood": "Collingwood Corner", | |||
There was a problem hiding this comment.
There are multiple "Collingwood"s in Canada, so we can't fix the NS one this way
ncloudioj
approved these changes
Feb 14, 2025
| # map is lazy, so items of `cities` would only be evaluated one by one if needed | ||
| cities = map(lambda fn: fn(city), CITY_NAME_NORMALIZERS) | ||
| explored_cities: list[str] = [] # store the explored cities to avoid duplicates | ||
| city = geolocation.city |
There was a problem hiding this comment.
Nit: let's add an early return here if city is None and then do:
city: str = typing.cast(str, geolocation.city) # `city` would never be None.
No moreif city: needed below.
There was a problem hiding this comment.
makes sense. Linter said city: str = typing.cast(str, geolocation.city) this was redundant though with the early return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3240
Description
Cities that require correction weren't used
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)