Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fenix to the full megazord. Fixes #1466 [ci full] #2565

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Jan 31, 2020

I think this is all we'd need to do.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • automation/all_tests.sh runs to completion and produces no failures
    • Note: For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@rfk
Copy link
Contributor

rfk commented Feb 25, 2020

Boom mozilla-mobile/fenix#8742

@ekager
Copy link

ekager commented Feb 25, 2020

FWIW I think FxR is also using the fenix-megazord so let's make sure they're updated to the full too :)
https://github.com/MozillaReality/FirefoxReality/blob/a81f0f08e8e4825dade804fcfc8ab30350ba038b/versions.gradle#L84

@rfk
Copy link
Contributor

rfk commented Feb 26, 2020

Thanks for the heads-up @ekager, I've made a start on a patch here: MozillaReality/FirefoxReality#2867

Copy link
Contributor

@rfk rfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r- this so we don't forget to add a changelog entry

@thomcc thomcc force-pushed the fenix-full-mz branch 2 times, most recently from d0cc2a8 to 1578c09 Compare February 26, 2020 18:54
Copy link
Contributor

@rfk rfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's do this thing!

@eoger eoger merged commit 113835c into master Feb 26, 2020
@eoger eoger deleted the fenix-full-mz branch February 26, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants